Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Upgrade installer dependencies #61

Merged
merged 1 commit into from
Oct 27, 2022
Merged

DEP Upgrade installer dependencies #61

merged 1 commit into from
Oct 27, 2022

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Oct 26, 2022
Closed
1 task
GuySartorelli
GuySartorelli approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really necessary but doesn't adversely affect anything, happy to merge.

@GuySartorelli GuySartorelli merged commit 82e30fc into silverstripe:2 Oct 27, 2022
@GuySartorelli GuySartorelli deleted the pulls/2/upgrade-installer-deps branch October 27, 2022 21:01
@michalkleiner
Copy link
Contributor

@sabina-talipova could you please check all the other PRs for the end-of-file new line change so that we don't keep merging that in? Appreciate it!

@sabina-talipova
Copy link
Contributor Author

@michalkleiner, thank that you point me to "end-of-file new line" issue.
Yes, I've checked and all other composer.json files had this line at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabina-talipova @michalkleiner @GuySartorelli