Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fast_read_data when reading the last line #580

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

kif
Copy link
Member

@kif kif commented Aug 20, 2024

close #578

Nice catch by the way !

@kif kif requested a review from payno August 20, 2024 13:11
Copy link
Member

@payno payno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ PR with more test than 'source code' 😃

@kif
Copy link
Member Author

kif commented Aug 21, 2024

Non regression tests are important, especially when one missed a corner case like here.

@kif kif merged commit 8a3a5eb into silx-kit:main Aug 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDFImage.fast_read_data: cannot read a line ?
2 participants