Fix CRA v5 compatibility by publishing lib and app as CommonJS packages #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Mar 8, 2022
|
Once merged, I'll do a beta release to double check. |
axelboc
commented
Mar 9, 2022
| "require": "./dist/index.cjs", | ||
| "import": "./dist/index.js" | ||
| "require": "./dist/index.js", | ||
| "import": "./dist/index.esm.js" |
There was a problem hiding this comment.
I had forgotten to change the cjs extension back to js ... not that it matters since we point to the exact filenames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #986
With
"type": "module", webpack v5 enforces Node-compliant paths. Forreact-icons/fi, this should bereact-icons/fi/index.esm.js, but if I do this in the codebase, then TypeScript complains that it can't find the types...I think this is linked to the way the
react-iconspackage is organised, but not sure it's worth reporting since it works fine with"type": "module"removed (or rather overridden with its default value"commonjs"when published).