Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prop to manually add components to overflow menu #1378

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Add prop to manually add components to overflow menu #1378

merged 1 commit into from
Mar 14, 2023

Conversation

PeterC-DLS
Copy link
Contributor

This is to address part of #1377 and allows us to move less commonly used toolbar buttons off the main bar

axelboc
axelboc approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this for now, as discussed in #1377 👍

@axelboc
Copy link
Contributor

axelboc commented Mar 14, 2023

Just need you to rebase on main so I can merge — I don't seem to be allowed to force-push myself.

@PeterC-DLS
Copy link
Contributor Author

No problem, done.

@axelboc axelboc merged commit c798ed2 into silx-kit:main Mar 14, 2023
@PeterC-DLS PeterC-DLS deleted the initial-overflows branch March 14, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelboc axelboc axelboc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterC-DLS @axelboc