Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in #1387 ... so much for bringing stacking under control 😓
The canvas was still stacked implicitly at
z-index: 0
, so in front of the grid and SVG elements... Sorry about that. So now it moves behind everything.Unfortunately, in doing so,
r3fRoot
—which is still stacked implicitly atz-index: 0
(and cannot be stacked explicitly without creating a new stacking context and breaking the stacking order, as explained in a comment in the CSS)—captures events before the reach the canvas... I had to work around this by movingpointer-events: none
tor3fRoot
instead of setting it on every overlay, and then re-enabling it toauto
on the canvas and floating toolbar.This feels better in the end, since it removes a bunch of
pointer-events: none
and saves us and consumers from forgetting to add them.Note that this may very well change when dealing with #1388. To be continued...