Clean up and improve Annotation
stories
#1466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on refactoring
Html
in #1465 , I noticed that theAnnotation
stories were in need of a good clean-up.I took full advantage of Storybook by splitting each annotation example into its own story, which means that the controls now work as expected and the props are properly listed in the Docs page.
I also:
Annotation
is no longer the recommended way to render SVG elements;overflowCanvas
.This actually uncovered a bug: annotations that overflow the canvas are not positioned properly, since they are positioned relatively to the
canvasWrapper
element, which includes the axes. I have an idea to fix this, but I'll continue working on declarative axes first.