Support h5grove@2.0.0 and improve dtype parsing #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Jan 29, 2024
packages/app/src/providers/h5grove/__snapshots__/h5grove-api.test.ts.snap
Show resolved
Hide resolved
packages/app/src/providers/h5grove/__snapshots__/h5grove-api.test.ts.snap
Show resolved
Hide resolved
packages/app/src/providers/h5grove/__snapshots__/h5grove-api.test.ts.snap
Outdated
Show resolved
Hide resolved
packages/app/src/providers/h5grove/__snapshots__/h5grove-api.test.ts.snap
Show resolved
Hide resolved
packages/app/src/providers/h5grove/__snapshots__/h5grove-api.test.ts.snap
Show resolved
Hide resolved
packages/app/src/providers/h5grove/__snapshots__/h5grove-api.test.ts.snap
Show resolved
Hide resolved
loichuder
approved these changes
Jan 29, 2024
|
|
||
| export interface H5GroveBaseType { | ||
| class: number; | ||
| dtype?: string; |
There was a problem hiding this comment.
Now that all the info is contained as fields in the object type, it is worth keeping the dtype field ?
There was a problem hiding this comment.
You mean in our front-end types? Yeah probably not!
There was a problem hiding this comment.
I kept it in the back-end because I thought that some front-ends (that don't care as much about supporting all the types) might find it more convenient to use - e.g. to display the dtype in a tooltip.
axelboc
force-pushed
the
h5grove-2
branch
3 times, most recently
from
f053d9e
to
80acdcc
Compare
axelboc
commented
Jan 30, 2024
| @@ -21,7 +21,7 @@ import type { | |||
| import { hasErrorMessage, parseEntity } from './utils'; | |||
|
|
|||
| export class H5GroveApi extends DataProviderApi { | |||
| /* API compatible with h5grove@1.3.0 */ | |||
| /* API compatible with h5grove@2.0.0b2 */ | |||
There was a problem hiding this comment.
Version bump (beta for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows silx-kit/h5grove#85.
I've encountered an issue upgrading the server on Bosquet, so the tests still fail for now.