Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flipping RGB visualizations on X and Y #1608

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Allow flipping RGB visualizations on X and Y #1608

merged 2 commits into from
Apr 12, 2024

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Apr 12, 2024

We received a request by email to allow flipping RGB visualizations on X and Y.

So far we were always applying a flip on Y. It is still the default, but users can now toggle it off (in addition to flipping on X if they like).

image

@axelboc
Copy link
Contributor Author

axelboc commented Apr 12, 2024

/approve

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documenting RgbVis while I'm at it.

@axelboc axelboc requested a review from loichuder April 12, 2024 12:51
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have kept flipY on by default but ok !

@axelboc
Copy link
Contributor Author

axelboc commented Apr 12, 2024

I would have kept flipY on by default but ok !

Yeah, why not.

@axelboc
Copy link
Contributor Author

axelboc commented Apr 12, 2024

/approve

@axelboc axelboc merged commit 22584d1 into main Apr 12, 2024
8 checks passed
@axelboc axelboc deleted the flip-rgb branch April 12, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants