Refactor OverflowMenu and InteractionHelp with Floating UI
#1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
axelboc
commented
May 21, 2024
There was a problem hiding this comment.
Fixing a regression in the alignment of the controls in the overflow menu (right-aligned brings them closer to the trigger). Note also that I've increased the clickable area of the buttons (orange outline).
loichuder
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selector menus, the export menu, and the overflow and interaction help popovers now all behave the same way in terms of focus management, dismissal, positioning, etc.
In this PR, I've also streamlined the CSS across all these components, simplified the DOM in a few places (unnecessary wrappers, etc.) and fixed a couple of flexbox alignment regressions that I've only just noticed.
I've left the
DomainWidgetalone for now because the toggling logic is more complex.