Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up toolbar deprecations #1653

Merged
merged 3 commits into from
May 28, 2024
Merged

Clean up toolbar deprecations #1653

merged 3 commits into from
May 28, 2024

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented May 22, 2024

Since #1652 has a breaking change, I go ahead and remove some deprecated components, as well as the obsolete align prop of ExportMenu. I also re-use the generic Btn component in ExportMenu, InteractionHelp and OverflowMenu and fix a small ARIA bug.

BREAKING

  • Remove deprecated components GridToggler and FlipYAxisToggler — use ToggleBtn directly instead.
  • [ExportMenu] Remove prop align — the popup now remains within the bounds of the viewport automatically, thanks to Floating UI.
  • [Btn] Prop onClick now receives the MouseEvent as first parameter, so make sure you don't pass a state setter as is, like onClick={toggleOpen}.

NEW FEATURE

  • [Btn] Add prop withArrow to display a drop-down arrow.
  • [Btn] Forward ref.
  • [Btn] Allow forwarding any valid attributes to the button element (HTMLAttributes<HTMLButtonElement>)

@axelboc axelboc requested a review from loichuder May 22, 2024 13:00
@axelboc axelboc changed the title Clean up deprecations Clean up toolbar deprecations May 22, 2024
@axelboc axelboc merged commit 27cb734 into main May 28, 2024
8 checks passed
@axelboc axelboc deleted the refactor branch May 28, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants