Load compression plugins for virtual datasets with h5wasm #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Jun 5, 2024
packages/h5wasm/src/h5wasm-api.ts
Outdated
Comment on lines
174
to
114
| const plugin = PLUGINS_BY_FILTER_ID[filter.id]; | ||
| if (!plugin) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn( | ||
| `Compression filter ${filter.id} not supported (${filter.name})`, | ||
| ); | ||
| continue; | ||
| } | ||
| const pluginsToLoad = allFilters | ||
| .map(({ id }) => PLUGINS_BY_FILTER_ID[id]) | ||
| .filter(isDefined); | ||
|
|
||
| for await (const plugin of pluginsToLoad) { |
There was a problem hiding this comment.
This just bring the code in line with H5WasmLocalFileProvider.
axelboc
force-pushed
the
virtual-sources
branch
2 times, most recently
from
bf4e056
to
fbd0eef
Compare
loichuder
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address silx-kit/vscode-h5web#43
Compression plugins required to read virtual datasets, which have compressed datasets as sources, are now loaded automatically in both
H5WasmProviderandH5WasmLocalFileProvider.h5wasm now exposes a
virtual_sourcesarray in theMetadataobject, which I parse and store in ourDatasetmodel. I then get the filters of every virtual source dataset located within the same file (file: '.') and load the corresponding compression plugins.By storing the virtual sources in the
Datasetmodel, we open the door to showing this information in theMetadataViewerin the future if the provider supports it.