Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Storybook and fix source code blocks #735

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Upgrade Storybook and fix source code blocks #735

merged 2 commits into from
Jun 30, 2021

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Jun 30, 2021

I was able to revert my fix for the source code blocks. They've fixed the decorators issue.

The release notes are a bit obscure -- I had to dig through some PRs to get to some of the changes: https://github.com/storybookjs/storybook/releases/tag/v6.3.0.

Worth noting are two new buttons in the toolbar: one to draw an outline around every DOM element, and an other to measure DOM elements by hovering them. They've also stabilised support for webpack 5, which might be handy when react-scripts finally decides to upgrade, and they've got experimental support for Vite, which is a toolchain I've been looking at for building the library once we move to a monorepo. Finally, they allow stories to be unit tested with Jest, which could be handy.

@axelboc axelboc requested a review from loichuder June 30, 2021 07:14
@axelboc
Copy link
Contributor Author

axelboc commented Jun 30, 2021

For some reason , the tests started failing because of a syntax issue in d3-array v3 that is not supported by Babel. I think upgrading Storybook changed the order of some dependencies in package-lock.json, leading to d3-array v3 being imported while v2 was previously being imported (v2 was still present because some other deps haven't upgraded d3-array to v3 yet).

Anyway, so I've downgraded d3-array, and I decided to start documenting problematic cases like this in CONTRIBUTING.md. I probably forgot some, but it's a start.

I've also removed @babel/core from package.json. Everything works fine without it, so I think whatever issue we had that made us add it is no longer relevant.

@axelboc
Copy link
Contributor Author

axelboc commented Jun 30, 2021

I'm really tempted to switch to yarn when we move to a monorepo, just so we can take advantage of this feature: https://classic.yarnpkg.com/en/docs/selective-version-resolutions/. NPM is working on a similar feature, but it's gonna take ages.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@loichuder
Copy link
Member

I'm really tempted to switch to yarn when we move to a monorepo, just so we can take advantage of this feature: https://classic.yarnpkg.com/en/docs/selective-version-resolutions/. NPM is working on a similar feature, but it's gonna take ages.

As you wish, I don't have any preference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants