Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated logging, code clean-up #191

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Updated logging, code clean-up #191

merged 1 commit into from
Oct 21, 2022

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Oct 21, 2022

This PR:

  • Provides a small update for the logging by providing the traceback in case of catched exception
  • Removes unsued registered_filters variable
  • Replaces "unknown" string by None for the ctypes lib object

@t20100 t20100 added this to the Next release milestone Oct 21, 2022
@t20100 t20100 requested a review from vasole October 21, 2022 09:33
vasole
vasole approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@vasole vasole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasole vasole merged commit 9d9a54f into silx-kit:main Oct 21, 2022
@t20100 t20100 deleted the logs-update branch October 21, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasole vasole vasole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@t20100 @vasole