Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split __init__.py into submodules #205

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Split __init__.py into submodules #205

merged 3 commits into from
Nov 22, 2022

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Nov 22, 2022

This PR splits the __init__.py into:

  • _filters.py which provides the filter IDs and configuration classes
  • _utils.py which provides the filter registration and get_config function.

The saving of the build configuration is changed from a dict to a namedtuple in setup.py to be used directly and avoid a circular import.

closes #202

@t20100 t20100 added this to the 4.0.0 milestone Nov 22, 2022
@t20100 t20100 requested a review from vasole November 22, 2022 11:01
vasole
vasole approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@vasole vasole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests are unmodified but continue to pass.

@vasole vasole merged commit 53127df into silx-kit:main Nov 22, 2022
@t20100 t20100 deleted the split-init branch November 22, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasole vasole vasole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Restructure hdf5plugin/__init__.py
2 participants
@t20100 @vasole