Dependencies: Requires python>=3.8; Removed deprecated constants: config, date, hexversion and strictversion
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
force-pushed
the
drop-python3.7
branch
3 times, most recently
from
de14c98
to
ae65590
Compare
t20100
changed the title
config, date, hexversion and strictversion
kif
reviewed
Jul 10, 2024
src/hdf5plugin/_version.py
Outdated
| "beta": 11, | ||
| "candidate": 12, | ||
| "final": 15} | ||
| def _version_info(version: str) -> _VersionInfo: |
There was a problem hiding this comment.
I would have made this function a class method, working as alternative constructor.
There was a problem hiding this comment.
I turned it to a _VersionInfo.from_string static method.
Simpler version handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge PR #313 first!
This PR prepares for v5 by:
hdf5plugin.config,hdf5plugin.date,hdf5plugin.hexversionandhdf5plugin.strictversionIt also cleans-up and simplifies some code:
MANIFEST.in_version.pyfile by storing the version as astrFinally, it removes Debian packaging configuration and script:
hdf5pluginis now officially packaged in Debian and unofficial packages can be created with wheel2deb.