Build Notifier send URL according to notification group tags. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cregev, |
…web/finala into feature/format-notifier-send-url
|
@kaplanelad I changed the Slack to have link per resource like you suggested. |
|
@kaplanelad I did not see you reviewed it again ... please let me know what do you think |
|
@cregev, i thinks you should add to URL the execution ID for support all messages |
|
@kaplanelad aligned the Slack links for the notifiers to have executionID in the link. |
kaplanelad
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/feature
What this PR does / why we need it:
We want Finala Notifier to send a Cost Report URL with the right query params to get the specific dashboard for the notification group