Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Redshift resource detection #74

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Add Redshift resource detection #74

merged 3 commits into from
Jun 30, 2020

Conversation

cregev
Copy link
Contributor

@cregev cregev commented Jun 27, 2020

What type of PR is this?

Backend Feature

What this PR does / why we need it:
Add redshift resource detection

@cregev cregev requested a review from kaplanelad June 27, 2020 11:46
@cregev cregev self-assigned this Jun 27, 2020
@cregev cregev added the kind/new-feature New feature label Jun 27, 2020
kaplanelad
kaplanelad suggested changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@kaplanelad kaplanelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Please see my little comment.
BTW, don't forget to update the helm chart with the new configuration

collector/aws/redshift.go Show resolved Hide resolved
@cregev cregev merged commit 8f94bb2 into master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaplanelad kaplanelad kaplanelad approved these changes

Assignees

@cregev cregev

Labels
kind/new-feature New feature lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cregev @kaplanelad