Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Implement EIP1559 support #215

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Conversation

ludowkm
Copy link
Contributor

@ludowkm ludowkm commented Nov 3, 2021

EIP-1559 is applied for a long time and most of web3 libs are supported it.

This PR is aim to solve this missing thing, it's enough to use EIP-1559 in web3dart.

@ludowkm
Copy link
Contributor Author

ludowkm commented Nov 3, 2021

#184

@ludowkm
Copy link
Contributor Author

ludowkm commented Nov 4, 2021

@simolus3 Can you please take a look on it to support this EIP?

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #215 (493b859) into master (4f2bed8) will decrease coverage by 2.40%.
The diff coverage is 61.70%.

❗ Current head 493b859 differs from pull request most recent head 693bc79. Consider uploading reports for the commit 693bc79 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   71.22%   68.82%   -2.41%     
==========================================
  Files          52       53       +1     
  Lines        2092     2181      +89     
==========================================
+ Hits         1490     1501      +11     
- Misses        602      680      +78     
Impacted Files Coverage Δ
lib/src/core/block_information.dart 0.00% <0.00%> (ø)
lib/src/core/client.dart 5.40% <0.00%> (-14.45%) ⬇️
lib/src/core/transaction_information.dart 48.10% <28.57%> (-1.22%) ⬇️
lib/src/core/transaction.dart 50.00% <60.00%> (+19.23%) ⬆️
lib/src/core/transaction_signer.dart 75.00% <73.68%> (+7.50%) ⬆️
lib/src/credentials/credentials.dart 64.10% <100.00%> (+1.94%) ⬆️
test/core/sign_transaction_test.dart 100.00% <100.00%> (ø)
lib/src/contracts/generated_contract.dart 0.00% <0.00%> (-42.86%) ⬇️
test/infura_integration_test.dart 53.33% <0.00%> (-40.01%) ⬇️
lib/src/generated/erc20.g.dart 0.00% <0.00%> (-15.52%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2bed8...693bc79. Read the comment docs.

@simolus3 simolus3 merged commit 2644b64 into simolus3:master Nov 4, 2021
@simolus3
Copy link
Owner

simolus3 commented Nov 4, 2021

Thank you! I have published this as 2.3.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants