remove txt paths for binning matrix and covmat #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itrharrison
requested changes
Mar 2, 2023
soliket/lensing/lensing.py
Outdated
| @@ -126,12 +124,32 @@ def get_requirements(self): | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
| def _get_data(self): | |||
| import sacc | |||
There was a problem hiding this comment.
Only import sacc once at the top.
soliket/lensing/lensing.py
Outdated
| def _get_data(self): | ||
| import sacc | ||
|
|
||
| s = sacc.Sacc.load_fits(self.datapath) |
There was a problem hiding this comment.
This could probably be refactored so the load_fits only needs to happen once, and the sacc gets stored as e.g. self.sacc_data
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 61.30% 61.52% +0.22%
==========================================
Files 30 30
Lines 1920 1931 +11
==========================================
+ Hits 1177 1188 +11
Misses 743 743
|
itrharrison
approved these changes
Mar 3, 2023
mgerbino
pushed a commit
that referenced
this pull request
Oct 4, 2023
* remove txt paths for binning matrix and covmat * load sacc only once --------- Co-authored-by: Frank Qu <frankqu@Franks-MacBook-Pro.local> Co-authored-by: Ian Harrison <itrharrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.