Address warnings in tox tests #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 61.52% 61.52%
=======================================
Files 30 30
Lines 1931 1931
=======================================
Hits 1188 1188
Misses 743 743
|
|
Most of the warnings have been addressed. The pkg_resources.declare_namespace DeprecationWarning remains, but I doubt we can address it ourselves. @itrharrison , there are 3 warnings raised by the cross-correlation test:
|
|
@itrharrison , tests on oldest supported versions fail because of the replacement of interp2d with RegularGridInterpolator. The latter did not support the "cubic" interpolation method in the oldest versions of scipy, while it does with the current. |
itrharrison
approved these changes
Mar 8, 2023
mgerbino
added a commit
that referenced
this pull request
Oct 4, 2023
* renamed TestLike to CheckLike in test_ccl.py * replaced distutils.version.Looseversion with packaging.version.Version * replaced deprecated interp2d with RegularGridInterpolator in clusters * flake8 compliant * removed python3.7 from env list in tox.ini * removed py3.7 from conda reqs * upgraded latest version to py3.8 * correct data types in shearkappa test file * edits to setup.cfg for pyversion bump and fgspectra from pip * mflike actually still required before #104 merged --------- Co-authored-by: Martina Gerbino <bradamante@martina.local> Co-authored-by: Ian Harrison <itrharrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed TestLike class in test_ccl.py to address warning:
[cannot collect test class 'TestLike' because it has a __init__ constructor (from: Login.py)](https://stackoverflow.com/questions/62460557/cannot-collect-test-class-testmain-because-it-has-a-init-constructor-from)