-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tests #136
Add missing tests #136
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 75.42% 77.79% +2.37%
==========================================
Files 30 30
Lines 1961 1932 -29
==========================================
+ Hits 1479 1503 +24
+ Misses 482 429 -53
|
@HTJense would you be able to help us out with the missing test for the |
Cosmopower only comes with CMB and P(k) networks pre-installed. To make a test, I would have to externally install networks that reproduce derived parameters (most likely Boris' networks, which are, as far as I am aware, the only publicly-available implementation of this type so far). While certainly possible, I didn't think it would be good practice to rely on many external packages like these. |
@HTJense okay, cool. I think the best course of action is to leave it uncovered alternatives would be to remove it... which seems a shame, or to mark it not for coverage... which would also be wrong I think just leaving it uncovered as a kind of 'todo' is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* added option to test poisson data with samples * addressing codestyle * addressing codestyle and fixing wrong path when in tox * addressing wrong path in tox * added test data for test cash lkl * polished test datapath acquisition * skipping unnecessary functions to cover in gaussian * skipped unnecessary functions in cosmpopower for coverage * added simple tes for binner in utils * cosmetics in test_utils * added test for binner in utils * Updated utils test and added utils documentation * documentation updated * cosmetics * cosmetics * cosmetics * codestyle compliant * tody up utils doc --------- Co-authored-by: Martina Gerbino <bradamante@martina.local> Co-authored-by: Ian Harrison <itrharrison@gmail.com>
This PR is work in progress towards reaching 85% test coverage. Starting from poisson data test.