Make code and test compatible with new version of mflike and Cobaya #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itrharrison
requested changes
Sep 25, 2021
There was a problem hiding this comment.
This looks good in both fixing the bugs with fgspectra installation, and with the cobaya.conventions in the new cobaya version, as well as doing some work with the new mflike.
Possibly in future it would be better to do the bug fixes as separate PRs which go in before the new functionality with mflike, but should not be a big problem for here as I don't think there is any conflicting work done elsewhere, apart from Jack's PR, but I think that can be superseded without too much wasted effort.
|
Hi @itrharrison the last push should solve the issue you mentioned |
itrharrison
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #20 and other incompatibilities: