codecov for coverage #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=========================================
Coverage ? 67.34%
=========================================
Files ? 29
Lines ? 1666
Branches ? 0
=========================================
Hits ? 1122
Misses ? 544
Partials ? 0 |
|
I'm not 100% convinced with how this is configured, but seeing as it doesn't touch any functionality, I feel like it is worthwhile seeing it in action. |
mgerbino
pushed a commit
that referenced
this pull request
Oct 4, 2023
* added coveralls and codecov * typo in gha * added coveralls official gha * try only gha * added path to coverage report * try codecov again! * codecov include report as comment * removed coveralls comment * eof new lines * updated codecov gha version, options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a few attempts playing around with both coveralls and codecov, this implements codecov for posting coverage reports on SOLikeT.
I have made it draft for now, will upgrade when I have seen that the reports post correctly as comments on the PR.
One improvement could be to only run the
--covflags on oneos, but this would require some small restructuring on how the tests are run.Merging this PR will close #39