Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cash-C likelihood #56

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Conversation

itrharrison
Copy link
Collaborator

I have implemented a Cash-C likelihood for use with e.g. the binned cluster counts.

I assumed the data was stored in a particular form:

        data = np.loadtxt(self.datapath, unpack=False)
        N = data[:, -1] # assume data stored like column_stack([z, q, N])
        x = data[:, :-1]

but that might not make sense in practise!

Merging will close #54 .

@itrharrison itrharrison added enhancement New feature or request clusters Related to clusters likelihoods labels Feb 23, 2022
@itrharrison itrharrison self-assigned this Feb 23, 2022
@itrharrison
Copy link
Collaborator Author

itrharrison commented Feb 23, 2022

I should also say that the fiducial likelihood values in the test came from using @eunseongleee 's implementation of the Cash likelihood on the binned_clusters branch, so hopefully my implementation is correct.

Copy link
Collaborator

@eunseongleee eunseongleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me!

@itrharrison itrharrison merged commit 4efa452 into simonsobs:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clusters Related to clusters likelihoods enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a Cash likelihood class
2 participants