-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sacc files and tracers for CrossCorrelation Likelihood #58
Conversation
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 67.34% 66.01% -1.33%
==========================================
Files 29 29
Lines 1666 1701 +35
==========================================
+ Hits 1122 1123 +1
- Misses 544 578 +34
|
* added deltaz nuisance model * working deltaz nuisance model * deltaz bug fizes for plotting * codestyle * nuisance parm for tracer2
I just updated the test for the The direct agreement is between unbinned theory curves here: whilst the test is done with a binned version of the data, which is in the data file and has agreement shown here: |
As an aside, I am maybe uncomfortable with the fact that I don't know if @damonge thinks this is worth a sacc (and/or CCL) Issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thanks for putting the work!
* initial commit with tracers * bandpower binning * move sacc data, bpw to parent calss * use_tracers in input, added bpw * use des x act toy sim * expanded tests * tests account for missing data file * bug fix on tracer selection * bug fix on tracer selection (actually this time) * Shear x kappa nuisance delta z (#67) * added deltaz nuisance model * working deltaz nuisance model * deltaz bug fizes for plotting * codestyle * nuisance parm for tracer2 * added m nuisance parameterisation * codestyle * fixes to z and m nuisance * added IA model * added hmcode test * codestyle * added data file for tests * added shearkappa test against lit result * removed commented plotting
This PR will change a lot about how the CCL-based CrossCorrelation likelihood will work.
So far I have added the ability to read sacc files and use the binning specified there to the
ShearKappaLikelihood
subclass.