Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sacc files and tracers for CrossCorrelation Likelihood #58

Merged
merged 25 commits into from
Aug 19, 2022

Conversation

itrharrison
Copy link
Collaborator

This PR will change a lot about how the CCL-based CrossCorrelation likelihood will work.

So far I have added the ability to read sacc files and use the binning specified there to the ShearKappaLikelihood subclass.

@itrharrison itrharrison added the crosscorrelation Related to the CrossCorrelation likelihood label Apr 19, 2022
@itrharrison itrharrison self-assigned this Apr 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #58 (7023a02) into master (5351ca2) will decrease coverage by 1.32%.
The diff coverage is 29.16%.

❗ Current head 7023a02 differs from pull request most recent head 238d9a6. Consider uploading reports for the commit 238d9a6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   67.34%   66.01%   -1.33%     
==========================================
  Files          29       29              
  Lines        1666     1701      +35     
==========================================
+ Hits         1122     1123       +1     
- Misses        544      578      +34     
Impacted Files Coverage Δ
soliket/cross_correlation.py 56.41% <29.16%> (-43.59%) ⬇️

@itrharrison itrharrison marked this pull request as ready for review August 8, 2022 16:15
@itrharrison itrharrison requested a review from Pablo-Lemos August 8, 2022 16:15
@itrharrison itrharrison added the enhancement New feature or request label Aug 8, 2022
@itrharrison
Copy link
Collaborator Author

itrharrison commented Aug 13, 2022

I just updated the test for the ShearKappaLikelihood which is now against data digitised from Figure 3. of https://arxiv.org/abs/1401.6018 with n(z) from Equation 8.

The direct agreement is between unbinned theory curves here:
cs82-planck_hall_unbinnned

whilst the test is done with a binned version of the data, which is in the data file and has agreement shown here:
cs82-validation

@itrharrison
Copy link
Collaborator Author

As an aside, I am maybe uncomfortable with the fact that sacc_data.get_bandpower_windows(bpw_idx).values was able to return floats which then cause ccl.cls.angular_cl to return zero, so I just cast them to ints.

I don't know if @damonge thinks this is worth a sacc (and/or CCL) Issue?

Copy link
Collaborator

@Pablo-Lemos Pablo-Lemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thanks for putting the work!

@itrharrison itrharrison merged commit 07b8709 into master Aug 19, 2022
@itrharrison itrharrison deleted the dev-shearxkappa-sacc branch March 3, 2023 09:49
mgerbino pushed a commit that referenced this pull request Oct 4, 2023
* initial commit with tracers

* bandpower binning

* move sacc data, bpw to parent calss

* use_tracers in input, added bpw

* use des x act toy sim

* expanded tests

* tests account for missing data file

* bug fix on tracer selection

* bug fix on tracer selection (actually this time)

* Shear x kappa nuisance delta z (#67)

* added deltaz nuisance model

* working deltaz nuisance model

* deltaz bug fizes for plotting

* codestyle

* nuisance parm for tracer2

* added m nuisance parameterisation

* codestyle

* fixes to z and m nuisance

* added IA model

* added hmcode test

* codestyle

* added data file for tests

* added shearkappa test against lit result

* removed commented plotting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crosscorrelation Related to the CrossCorrelation likelihood enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants