Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hartlap and post-Hartlap corrections for GaussianData #81

Merged
merged 7 commits into from
Nov 20, 2022
Merged

Add Hartlap and post-Hartlap corrections for GaussianData #81

merged 7 commits into from
Nov 20, 2022

Conversation

itrharrison
Copy link
Collaborator

See #78 for details.

@itrharrison itrharrison added the enhancement New feature or request label Oct 25, 2022
@itrharrison itrharrison self-assigned this Oct 25, 2022
@itrharrison itrharrison linked an issue Oct 25, 2022 that may be closed by this pull request
Add Hartlap and post-Hartlap corrections as option in likelihoods #78
Closed
@itrharrison
Copy link
Collaborator Author

Currently adds Hartlap factor to single GaussianData only.

@itrharrison itrharrison marked this pull request as ready for review October 26, 2022 13:40
@itrharrison
Copy link
Collaborator Author

@shabbir137 has some nice code for a toy model of Hartlap correction, which would make a great test here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022 •
edited
Loading

Codecov Report

Merging #81 (ee7db22) into master (7bf4121) will increase coverage by 0.25%.
The diff coverage is 93.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   75.71%   75.96%   +0.25%     
==========================================
  Files          29       31       +2     
  Lines        1795     1822      +27     
==========================================
+ Hits         1359     1384      +25     
- Misses        436      438       +2
Impacted Files Coverage Δ
soliket/studentst.py 83.33% <83.33%> (ø)
soliket/gaussian.py 69.73% <100.00%> (+0.40%) ⬆️
soliket/gaussian_data.py 87.00% <100.00%> (+0.54%) ⬆️
soliket/studentst_data.py 100.00% <100.00%> (ø)

HTJense
HTJense approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@HTJense HTJense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Tests passed locally). Seems good to me.

@itrharrison itrharrison merged commit e305cb2 into master Nov 20, 2022
@itrharrison itrharrison mentioned this pull request Feb 1, 2023
Merged
@itrharrison itrharrison deleted the dev-78-hartlap branch March 3, 2023 09:49
mgerbino pushed a commit that referenced this pull request Oct 4, 2023
@itrharrison
Add Hartlap and post-Hartlap corrections for GaussianData (#81)
a4ea630 
* added hartlap factor for single gaussiandata

* added studentst likelihood, test

* improved hartlap test

* forgot to add students-t files!

* remove students-t for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HTJense HTJense HTJense approved these changes

@shabbir137 shabbir137 Awaiting requested review from shabbir137

Assignees

@itrharrison itrharrison

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Hartlap and post-Hartlap corrections as option in likelihoods
3 participants
@itrharrison @codecov-commenter @HTJense