Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exception and fallback for cosmopower not available #83

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

itrharrison
Copy link
Collaborator

See #82. Allows for working installation without cosmopower.

@itrharrison itrharrison added bug Something isn't working theory Related to cobaya Theories labels Nov 3, 2022
@itrharrison itrharrison requested a review from HTJense November 3, 2022 09:53
@itrharrison itrharrison self-assigned this Nov 3, 2022
@itrharrison itrharrison linked an issue Nov 3, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #83 (c6d05de) into master (d8d80a9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   75.97%   76.00%   +0.02%     
==========================================
  Files          29       29              
  Lines        1815     1817       +2     
==========================================
+ Hits         1379     1381       +2     
  Misses        436      436              
Impacted Files Coverage Δ
soliket/cosmopower.py 100.00% <100.00%> (ø)

Copy link
Member

@HTJense HTJense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@itrharrison itrharrison merged commit b21cbc7 into master Nov 3, 2022
@itrharrison itrharrison deleted the dev-82-cosmopower-option branch March 3, 2023 09:49
mgerbino pushed a commit that referenced this pull request Oct 4, 2023
* added exception and fallback for cosmopower not available

* Minor typo

Co-authored-by: Hidde Jense <JenseH@cardiff.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working theory Related to cobaya Theories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CosmoPower not actually optional
3 participants