cache-control: private is playing havoc with performance

[simonw]

In #6 we disabled all caching for logged in users.

datasette-auth-github/datasette_auth_github/github_auth.py

Lines 138 to 145 in b3aaa4c

	# Rebuild headers to include cache-control: private
	original_headers = event.get("headers") or []
	new_headers = [
	[key, value]
	for key, value in original_headers
	if key.lower() != b"cache-control"
	]
	new_headers.append([b"cache-control", b"private"])

It turns out this is causing really nasty performance issues when running with other plugins such as datasette-vega! See simonw/datasette#586

[simonw]

[simonw]

I'm going to fix this by having the code NOT apply cache-control: private to anything within the /-/static directory - but only when the ASGI middleware is being used by Datasette.

This means I'll add an opt-out mechanism that other users of the middleware can potentially tap into.