Fix support for Python template syntax #429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or escaped identifiers. The previous implementation failed with doubled dollar signs, which, according to the Python template syntax, should be used to escape a single dollar sign. Additionally added a test for a template containing an escaped dollar sign.
Added a version check that uses `string.Template.get_identifiers` if Python is > 3.11, falls back to a reimplementation.
|
Tests failed on Python 3.8: I'll fix that now. |
|
Sorry for the bad code, I should figure out how to run the tests locally. |
|
There, that should do it. Sorry for the noise, I was apparently coding on half a brain last week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All dollar signs in a template's
promptorsystemvalues are interpreted as introducingplaceholders. The documentation forstring.Templatesays that doubling a dollar sign should escape it.Due to the custom implementation of
Template.extract_vars, this did not work, as it extracted a double dollar sign as an identifier with an empty named group. By usingstring.Template.get_identifiers()instead, this now works. Additionally, this automatically adds support for parenthesized identifiers as well.