Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some website cannot crop or wrong result #2

Open
iamkwan opened this issue Nov 12, 2016 · 6 comments
Open

Some website cannot crop or wrong result #2

iamkwan opened this issue Nov 12, 2016 · 6 comments

Comments

@iamkwan
Copy link

iamkwan commented Nov 12, 2016

I found that there are some website cannot trigger the jCrop or wrong result
for example:
Cannot crop
https://chrome.google.com/webstore/category/apps?hl=zh-TW&_feature=website

I dont know how to say this problem
http://deepliquid.com/content/Jcrop_Examples.html

also this extension need create element in current page, so all non web page cannot crop anything

And current my extension is use captureVisibleTab to send the base64 image to new tab
and set the jCrop with it, so i dont have above problem

@simov
Copy link
Owner

simov commented Nov 12, 2016

There are certain sites that are not allowed for Chrome extensions like for example the Chrome Store.

Having the jCrop plugin initialized on the page and using the Screenshot Capture extension would most probably cause issues. I'll add it to my TODO list to think about it, but it's not a high priority one.

What do you mean by non web pages? File URLs, those starting with file:///? Seems to be working on my end.

@iamkwan
Copy link
Author

iamkwan commented Nov 12, 2016

Non web page
Eg. Chrome extension page, which enable the development mode
On Nov 12, 2016 11:22 PM, "simo" notifications@github.com wrote:

There are certain sites that are not allowed for Chrome extensions like
for example the Chrome Store.

Having the jCrop plugin initialized on the page and using the Screenshot
Capture extension would most probably cause issues. I'll add it to my TODO
list to think about it, but it's not a high priority one.

What do you mean by non web pages? File URLs, those starting with
file:///? Seems to be working on my end.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIfvVv2gaTJUIA_SlgxH9KCodkHtfCzLks5q9dm4gaJpZM4KwcGu
.

@simov
Copy link
Owner

simov commented Nov 12, 2016

These are not allowed too :) I think there is an option to allow it though. Check out this answer on StackOverflow.

@iamkwan
Copy link
Author

iamkwan commented Nov 12, 2016

If you crop in current page it must not allow,
But in my case I don't have above problem cuz I capture the screen and send it to new tab assign it in img element and initialize the jCrop

@simov
Copy link
Owner

simov commented Nov 12, 2016

That's a good workaround, thanks for sharing it 👍 I'll think about adding it to the extension, but that's not a high priority one too.

@pranaymmf
Copy link

Can we show buttons with the J crop preview like i want to add a save and delete button with that preview can we???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants