This repository has been archived by the owner on Apr 23, 2021. It is now read-only.
Add version information to CUDS HDF5 file #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 7, 2015 17:35
"cuds_version" is added to the Mesh, Lattice and Particle components to version their layouts/structure in their node in the HDF5 file
|
@itziakos @roigcarlo @tuopuu @SGGgarcia , this is ready to be reviewed and merged. thanks. (i am out of the office till tuesday) |
| @@ -4,6 +4,8 @@ | |||
| from simphony.io.h5_mesh import H5Mesh | |||
| from simphony.io.h5_lattice import H5Lattice | |||
|
|
|||
| _file_version = 1 | |||
There was a problem hiding this comment.
I would suggest to capitalize and probably rename to H5FILE_VERSION
|
one minor comment from me |
|
Looks ok 👍 Same suggestion as Ioannis. |
|
@itziakos , @SGGgarcia : Thanks. Made the change. |
roigcarlo
added a commit
that referenced
this pull request
Jul 13, 2015
Add version information to CUDS HDF5 file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #156 by adding version information to the CUDS HDF5 file. Specifically, a 'cuds_version' was added as an HDF5-attribute of type
intto:Only a single individual version (the latest) is supported and an exception is thrown when reading files containing a different version.
See discussions in issue #156 for more detail on versioning. In general, when a developer changes the top level layout (i.e. root), then the top level 'cuds-version' should be incremented for that release of SimPhoNy. When a developer changes the layout of the CUDS container components, that's 'cuds_version' should be incremented for that release of SimPhony and the top-level version (i.e. root) should also be incremented.
This PR doesn't update the UML images (see #179)