WIP: Add internal wrappers #32
Conversation
version 0.1.3 of simphony-lammps-md now requires the lammps python module. The module uses the python wrapper to the LAMMPS library which needs to load the liblammps.so; we are currently adding the libraries location to LD_LIBRARY_PATH when testing the plugin
Updating the version of simphony-jyulb requires that (i) the master of jyulb was used as jyulb version 0.1.0 no longer works for simphony-version 0.1.2 and (ii) that we had to use "python setup.py develop" instead of "python setup.py install" due to problems when running the tests.
| rm -Rf src/lammps | ||
| @echo | ||
| @echo "Lammps solver installed" | ||
|
|
||
| jyu-lb: | ||
| rm -Rf src/JYU-LB | ||
| git clone --branch 0.1.0 https://github.com/simphony/JYU-LB.git src/JYU-LB | ||
| git clone --branch master https://github.com/simphony/JYU-LB.git src/JYU-LB |
There was a problem hiding this comment.
You should always checkout a tag of a stable release. master is not a safe choice
There was a problem hiding this comment.
Yeah, agree. simphony-jyulb 0.1.2 fails with JYU-LB 0.1.0. I have created an issue at simphony/simphony-jyulb#22
|
@nathanfranklin, I had a quick review. It looks that integration is in the right path. We should push however for haste in the necessary fixes from the collaborators to avoid problems down the line. |
I totally agree. There are the three workaround-fixes that are currently added in this PR and then work-around for simphony/simphony-openfoam#25 . It would be best if these issues were all fixed (and related fixes in the makefile were removed) before we merge this PR. There are solutions for each of these issues so it should be doable (although i have temporarily given up on the lammps-library one). |
I have not looked into the details, but the poor mans solution is to manipulate the |
simphony-numerrin currently requires that the tests be run from a specific directory.
numerrin requires a license so the testing is optional and can be activated with setting the HAVE_NUMERRIN enviroment variable to "yes"
|
This is being replaced by #36 |
This PR adds the released INTERNAL wrappers to modeling engines.