Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Upgrade common 0.2.2 #63

Merged
merged 25 commits into from
Jan 18, 2016
Merged

Upgrade common 0.2.2 #63

merged 25 commits into from
Jan 18, 2016

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented Jan 13, 2016

No description provided.

@kitchoi
Copy link
Contributor Author

kitchoi commented Jan 13, 2016

simphony-aviz currently does not support simphony-common 0.2.2 but this may be fixed within this week. So we can wait a bit on that before making a release. (Edit: It is updated)

The Travis CI error on the push build is due to the fact that travis was particularly slow last night, so the job ran overtime and was canceled.

@kitchoi
Copy link
Contributor Author

kitchoi commented Jan 13, 2016

I also asked for a release for simphony-kratos. ref simphony/simphony-kratos#23

@kitchoi
Copy link
Contributor Author

kitchoi commented Jan 14, 2016

@nathanfranklin The integration release is almost ready to go. However I don't have a numerrin license for testing purposes. Do you have one and can you try it on your end please?

@nathanfranklin
Copy link
Member

@kitchoi , I just tested it. All tests pass.

@nathanfranklin
Copy link
Member

The line (https://github.com/simphony/simphony-framework/blob/upgrade-common-0.2.2/Makefile#L286) can be changed from:
(cd src/simphony-openfoam; haas foam_controlwrapper foam_internalwrapper -v)
to
haas foam_controlwrapper foam_internalwrapper -v)

as the simphony-openfoam devevelopers have addresssed simphony/simphony-openfoam#25

@nathanfranklin
Copy link
Member

Related to that, I suspect that https://github.com/simphony/simphony-framework/blob/upgrade-common-0.2.2/Makefile#L223-L228 and https://github.com/simphony/simphony-framework/blob/upgrade-common-0.2.2/Makefile#L75 could changed so that we don't need to keep src/simphony-numerrin after the installation occurs. Note that I haven't tested this...

@nathanfranklin
Copy link
Member

I think simphony/simphony-numerrin#5 is closed so in theory we no longer have to run the tests in src/simphony-numerrin. However, I tried running
haas numerrin_wrapper -v instead of cd src/simphony-numerrin; haas numerrin_wrapper -v (https://github.com/simphony/simphony-framework/blob/upgrade-common-0.2.2/Makefile#L24) but no tests were run. I don't know what is going on there.

@kitchoi
Copy link
Contributor Author

kitchoi commented Jan 14, 2016

@nathanfranklin I changed how simphony-numerrin is installed and tested. Could you try again please?

@nathanfranklin
Copy link
Member

@kitchoi , i used the framework to install/test simphony-numerrin. 👍

@kitchoi
Copy link
Contributor Author

kitchoi commented Jan 18, 2016

@nathanfranklin. @itziakos is it good to merge and release?

@nathanfranklin
Copy link
Member

👍

kitchoi added a commit that referenced this pull request Jan 18, 2016
@kitchoi kitchoi merged commit c82a813 into master Jan 18, 2016
@kitchoi kitchoi deleted the upgrade-common-0.2.2 branch January 20, 2016 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants