Revert encoding replace #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2608b9d. Replaced by: simplecov-ruby/simplecov#866 As suggested by: #91 (comment) Should be safe to revert as apparently ruby itself doesn't work when the encoding isn't declared properly so should be good. For files that aren't required by ruby but tracked we added a test case with broken encoding (in simplecov main) but it still seems to work. So this complexity is likely not needed anymore.
|
Probably can't/shouldn't revert due to jruby/jruby#6093 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2608b9d.
Replaced by: simplecov-ruby/simplecov#866
As suggested by: #91 (comment)
Should be safe to revert as apparently ruby itself doesn't work
when the encoding isn't declared properly so should be good.
For files that aren't required by ruby but tracked we added a
test case with broken encoding (in simplecov main) but it still
seems to work. So this complexity is likely not needed anymore.