Determine if use of guard clauses should be enforced

[craiglittle]

As per @colszowka's request, this issue is for discussion between the contributors to determine if the Style/GuardClause cop should be enabled. This came up while bringing the codebase into compliance with the latest rubocop version. For the time being, the cop has been disabled.

Here's the existing method in the codebase that raised this question.

For what it's worth, my two cents: I like that the use of guard clauses, where appropriate, reduces the level of indentation in a method, so I'm in favor of enabling the cop.

[colszowka]

/cc @bf4 @sferik @xaviershay @amatsuda Gentlemen, what do you think?

Personally I'd prefer a simple if/else statement over a guard clause any time because it is easier to parse the control flow of the method this way imho, so I'd drop this particular cop.

[xaviershay]

I tend to prefer guard clause but don't think this is a thing that should be enforced by rubocop either way - depends on code context too much.

[sferik]

👍 to what @xaviershay said.

[craiglittle]

Agreed! Context matters a lot with this technique. I think it makes sense to proceed with the cop turned off.

Closing this out...

[colszowka]

Thanks for giving your thoughts everyone, let's keep it this way then! 👏