Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status of JRuby Support #524

Closed
hube opened this issue Sep 30, 2016 · 4 comments · Fixed by #547
Closed

Status of JRuby Support #524

hube opened this issue Sep 30, 2016 · 4 comments · Fixed by #547

Comments

@hube
Copy link

hube commented Sep 30, 2016

What is the status of support for the various flavors of Ruby, in particular JRuby? Is JRuby 9000 supported? What about JRuby 1.7? The "Ruby version compatibility" section of the README has not been updated since 2011.
@olleolleolle
Copy link
Contributor

Hi!

Since 3 months, the Travis build includes JRuby HEAD: 21e2dd8

The Travis build matrix shows that the test suite passes on jruby-head, although it sits among the "Allowed failures".

@PragTob
Copy link
Collaborator

PragTob commented Nov 23, 2016

FWIW I used to always happily use simplecov with JRuby and it seemed to work fine. These days on one of build tasks (that executes MORE) it only recognizes 2 files and then covers 73/94 lines while the task executing less is at 2619 / 2791 :'(

@PragTob PragTob mentioned this issue Nov 23, 2016
Closed
@PragTob
Copy link
Collaborator

PragTob commented Nov 23, 2016

It was preemptive and I should have looked at myself before.. some code changes lead to code being required before simplecov which of course it the ultimate rookie mistake. Can confirm working on JRuby 👍

PragTob added a commit that referenced this issue Jan 25, 2017
@PragTob
Officially Support JRuby 9.1+
ad79c76 
I've personally been running simplecov with JRuby 1.7+ for years
so I'd say it is good to go either way ;P

The reality of edge cases is more complicated but it seems the
fine folks at @jruby (namely @enebo ) made the last fixes
necessary as seen in jruby/jruby#1196 so that they're available
in 9.1+ releases! The others should work, but have some little
failures (9.0.5.0 fails on one cuke for me).

So, the easiest way forward is to support 9.1+. Sadly the tests
take a while as they always start new interpreter instances and
startup time isn't exactly JRuby's strength, but CI does it
so it's bearable. :)

If anyone has problems with JRuby on a PR, in an issue or whatever
please feel free to ping me (@PragTob)

Also, special thanks goes to @donv who created did a lot of testing,
issue reporting et. al. for simplecov on JRuby for a long time!

* fixes #524
@PragTob PragTob mentioned this issue Jan 25, 2017
Merged
@hube
Copy link
Author

hube commented Jan 26, 2017

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Officially Support JRuby 9.1+ simplecov-ruby/simplecov
3 participants
@olleolleolle @hube @PragTob