Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of a Ruby 2.4 compatible version #544

Closed
spickermann opened this issue Jan 5, 2017 · 11 comments
Closed

Release of a Ruby 2.4 compatible version #544

spickermann opened this issue Jan 5, 2017 · 11 comments

Comments

@spickermann
Copy link

spickermann commented Jan 5, 2017

Hi @colszowka

I noticed that the current master is already compatible with Ruby 2.4 and for example the Fixnum deprecation warning is already removed (see: 050eb68). Great.

What are your plans about releasing a new version of simplecov?

Cheers.

@dreyks
Copy link

dreyks commented Jan 11, 2017

Also why not drop the dependency on json gem entirely since it's been in Ruby stdlib since at least 2.0.0?

I'm posting in this issue because json gem is what prevented me from using simplecov on 2.4

@PragTob
Copy link
Collaborator

PragTob commented Jan 11, 2017

@dreyks this gem still supports ruby 1.9.3 so that's why it can't be removed. Maybe at some point in the future support may be dropped but not now for all that I can tell/say :)

@spickermann
Copy link
Author

Hi @colszowka,

I do not want to bully you. But I wonder when the next, a Ruby 2.4 compatible version of simplecov will be released.

From my point of view the current master seems to be compatible with Ruby 2.4. Is there something that blocks a release? Is there something that still needs to be done? Perhaps something I can do or where I can help?

Cheers.

@colszowka
Copy link
Collaborator

@spickermann The changelog needs to be updated prior to releasing, based on v0.12.0...master

I've been intending to do that for the past two weeks but keep bumping into other stuff I need to do in the evenings, so didn't get around to it yet. If someone wants to go through the commit list and compile the changelog as a PR, that would be excellent. Please also mention that you're doing this here so we don't end up doing the work three times over ❤️

@PragTob
Copy link
Collaborator

PragTob commented Jan 23, 2017

@colszowka I will do that this evening :)

@colszowka
Copy link
Collaborator

colszowka commented Jan 23, 2017

@PragTob Thanks a lot!

Also, I've finally added you to the collaborators und rubygems owners here and on simplecov-html.

@bf4 @xaviershay @sferik @amatsuda I've recently suggested to @PragTob to join the team when we met at a user meetup - in addition to a variety of great things he's doing for the Ruby community he's actively using simplecov with JRuby and can therefore help us make SimpleCov support for JRuby official. Welcome on board Tobi! And, somewhat related: Thanks everyone already aboard for all your wonderful help with maintaining this project for the past years!

@PragTob
Copy link
Collaborator

PragTob commented Jan 23, 2017

Thanks :) I also have the honor of vaguely knowing @bf4 and knowing @sferik rather well so I guess we'll get along well =D

👋 @xaviershay @amatsuda

@PragTob
Copy link
Collaborator

PragTob commented Jan 23, 2017

🌟 #546 🌟

@PragTob
Copy link
Collaborator

PragTob commented Jan 25, 2017

🎉 0.13.0 🎉

@PragTob PragTob closed this as completed Jan 25, 2017
@PragTob
Copy link
Collaborator

PragTob commented Jan 25, 2017

Also, of course please test this out and if you encounter any issues please let us know! :)

@colszowka
Copy link
Collaborator

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants