Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 2.4.0 to Travis CI. #1075

Closed
wants to merge 1 commit into from

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented Feb 1, 2017

Add Ruby 2.4.0 to Travis CI.

@junaruga
Copy link
Contributor Author

junaruga commented Feb 1, 2017

https://travis-ci.org/cucumber/cucumber-ruby/builds/197415458

Travis failed for only Ruby 2.4.0 test.
Because Travis rvm 2.4.0's installed simplecov-0.12.0 warns because of Ruby 2.4.0 Fixnum/Bignum warning feature.

expected `"/home/travis/.rvm/gems/ruby-2.4.0/gems/simplecov-0.12.0/lib/simplecov/configuration.rb:207: warning:...0/gems/simplecov-0.12.0/lib/simplecov/source_file.rb:30: warning: constant ::Fixnum is deprecated\n".empty?` to return true, got false (RSpec::Expectations::ExpectationNotMetError)

features/docs/cli/specifying_multiple_formatters.feature:23:in `Then the stderr should not contain anything'

@junaruga
Copy link
Contributor Author

junaruga commented Feb 1, 2017

Latest version simplecov 0.13.0 is Ruby 2.4.0 compatibility.
simplecov-ruby/simplecov#544

@junaruga
Copy link
Contributor Author

junaruga commented Feb 1, 2017

Possible solutions are

  1. Update simplecov to latest version 0.13.0 by setting of .travis.yml before_install.
before_install:
  - gem update simplecov
  1. Wait and use coveralls's next version release depending on simplecov 0.13.0.
    Same situation with Fix test suite for Ruby 2.4 compatibility. cucumber-ruby-core#120

@junaruga
Copy link
Contributor Author

junaruga commented Feb 9, 2017

Close this PR because of #1077 .

@junaruga junaruga closed this Feb 9, 2017
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant