Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command name detecting for capybara 2.0 #186

Conversation

betelgeuse
Copy link
Contributor

With files named spec/features/foobar_spec.rb simplecov detected the
command as Cucumber Features. Now it looks at $PROGRAM_NAME first and
makes the proper guess for RSpec.

With files named spec/features/foobar_spec.rb simplecov detected the
command as Cucumber Features. Now it looks at $PROGRAM_NAME first and
makes the proper guess for RSpec.
@ersatzryan
Copy link
Contributor

Used your feature test for this, but solved it by just modifying the current setup a bit.

#212

@colszowka
Copy link
Collaborator

Thanks guys, merged #212 by @ersatzryan, so closing this.

@colszowka colszowka closed this Mar 23, 2013
@betelgeuse
Copy link
Contributor Author

I think mine would have been more future proof but at least the issue is solved.

@betelgeuse
Copy link
Contributor Author

Also copy pasting code from other people without the commit giving them any credit and opening a new pull request is just wrong.

@colszowka
Copy link
Collaborator

@betelgeuse The thing with $PROGRAM_NAME is that it isn't very reliable. There's about a million ways to run test suites, the bins supplied with rspec, cucumber etc. only being one of them. Add in things like spork, spin, zeus, guard, rake, railties etc., and it is very unlikely to catch all possible scenarios from the program name.

Though I am sorry you didn't get a commit contribution credit the way it happened, I had added your name to the changelog in this commit. If you want to get into the github contributors list, send me a noop PR on the cuke you wrote so you get your name on the contributions page.

@betelgeuse
Copy link
Contributor Author

@colszowka true it doesn't replace fully the path detection but that's why there's a fallback. The point was that if the executable matches rspec or cucumber then regardless of what the path step says we are dealing with them. Probably the most full proof solution would then be have the program name detection in addition to the changes already integrated.

@betelgeuse
Copy link
Contributor Author

What's the github contributions page? I am not sure if I have seen that before so could you provide a link so that I can see what it's about and learn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants