Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ruby warnings #213

Merged
merged 2 commits into from
Nov 10, 2013
Merged

Remove Ruby warnings #213

merged 2 commits into from
Nov 10, 2013

Commits on Mar 25, 2013

  1. Remove Ruby warning 

    `lib/simplecov/jruby16_fix.rb:31: warning: assigned but unused variable - e`

The previous catch-all `rescue` was used to swallow this exception:
`Errno::ENOENT: No such file or directory - test/fixtures/generated_buddha.rb`
We now make sure the file is present with `File.file?`.

Also reverts 6f71109 and moves the fix
into jruby_fix.rb to keep JRuby fixes in the same file.
    @infertux
    infertux committed Mar 25, 2013
    Configuration menu
    Copy the full SHA
    b9e3617 View commit details
    Browse the repository at this point in the history

  2. Remove Ruby warning 

    `lib/simplecov/defaults:57: warning: instance variable @exit_status not initialized`

We now ensure that @exit_status is always initialized.

Also did some cosmetic arrangements with no functional changes.
    @infertux
    infertux committed Mar 25, 2013
    Configuration menu
    Copy the full SHA
    221a74e View commit details
    Browse the repository at this point in the history