Unfreeze SimpleCov::VERSION #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In older versions of rubygems, in particular 1.8.23, Gem::Version#new
calls .strip! (as opposed to .strip) on the provided version. In some
cases, this constant is passed into that method causing it to raise an
exception ("can't modify frozen String"). This is discussed further
here:
https://github.com/colszowka/simplecov/pull/448/files#r52428872
That constant needs to be mutable to support older rubies. https://github.com/colszowka/simplecov/pull/448/files#r52428872 This change doesn't appear to be required, rubocop does not complain with or without it. This makes it pretty hard to verify I'm doing the right thing.
colszowka
added a commit
that referenced
this pull request
Feb 10, 2016
|
Thanks! |
craiglittle
pushed a commit
to craiglittle/simplecov
that referenced
this pull request
Feb 13, 2016
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Oct 9, 2016
0.12.0 2016-07-02 ([changes](simplecov-ruby/simplecov@v0.11.2...v0.12.0)) ================= ## Enhancements * Add support for JSON versions 2.x ## Bugfixes * Fix coverage rate of the parallel_tests. See [#441](simplecov-ruby/simplecov#441) (thanks @sinsoku) * Fix a regression on old rubies that failed to work with the recently introduced frozen VERSION string. See [#461](simplecov-ruby/simplecov#461) (thanks @leafle)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of rubygems choke on an immutable version string.
I wasn't able to actually get rubocop to complain about the mutable constant so I couldn't verify that the second commit actually does anything.