Remove Rubinius/rbx from the test matrix #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keen eyes might have observed that in #547 while reformatting the section about supported rubies I also removed the mention of Rubinius. I did this as it said they were just tested to make sure they don't crash which wasn't true anymore - full test suite is run but it was set to allowed failures. Sadly Rubinius hasn't been running/installing at all on travis for quite some time: https://travis-ci.org/colszowka/simplecov/jobs/169209429 And before when it was still running it was failing on a lot of cukes: https://travis-ci.org/colszowka/simplecov/jobs/141918713 As tests don't run/no one looks at aren't worth much I'm inclined to drop it from the test matrix, plus my recent experience with getting it running hasn't been stellar. We might always readd once they get their new interpreter and JIT going.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keen eyes might have observed that in #547 while reformatting the
section about supported rubies I also removed the mention of
Rubinius. I did this as it said they were just tested to make sure
they don't crash which wasn't true anymore - full test suite is run
but it was set to allowed failures.
Sadly Rubinius hasn't been running/installing at all on travis for
quite some time: https://travis-ci.org/colszowka/simplecov/jobs/169209429
And before when it was still running it was failing on a lot of
cukes: https://travis-ci.org/colszowka/simplecov/jobs/141918713
As tests don't run/no one looks at aren't worth much I'm inclined
to drop it from the test matrix, plus my recent experience with
getting it running hasn't been stellar.
We might always readd once they get their new interpreter and JIT
going.