Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making of conditional closed-generic registrations is not restricted when AllowOverridingRegistrations is true #216

Closed
dotnetjunkie opened this issue Apr 7, 2016 · 1 comment
Closed

Making of conditional closed-generic registrations is not restricted when AllowOverridingRegistrations is true #216

dotnetjunkie opened this issue Apr 7, 2016 · 1 comment
Assignees
@dotnetjunkie
Labels
bug task
Milestone
v3.1.3

Comments

@dotnetjunkie
Copy link
Collaborator

The making of condition registrations is disallowed when AllowOverridingRegistrations is set to true, because because it is impossible for the container to detect whether the registration should replace a different registration or not.

The container however currently allows conditional registrations for closed-generic types to be made, while non-generic and open-generic registrations are blocked. This is inconsistent and incorrect behavior, which can lead to hard to track bugs.
@dotnetjunkie dotnetjunkie added this to the v3.1.3 milestone Apr 7, 2016
@dotnetjunkie dotnetjunkie self-assigned this Apr 7, 2016
dotnetjunkie pushed a commit that referenced this issue Apr 7, 2016
Bug fix in RegisterConditional.
6859b36 
Registration of conditional closed-generic types prevented when
container allows overriding registrations. (fixes #216)
@dotnetjunkie
Copy link
Collaborator Author

Fixed in v3.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dotnetjunkie dotnetjunkie

Labels
bug task
Projects
None yet
Milestone
v3.1.3
Development

No branches or pull requests
1 participant
@dotnetjunkie