Remove Unused Object Array Check (#348)

sinclairzx81 · Mar 22, 2023 · 5289038 · 5289038
1 parent 5df81a9
commit 5289038
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sinclair/typebox",
-  "version": "0.26.0",
+  "version": "0.26.1",
   "description": "JSONSchema Type Builder with Static Type Resolution for TypeScript",
   "keywords": [
     "typescript",

diff --git a/src/compiler/compiler.ts b/src/compiler/compiler.ts
@@ -253,7 +253,6 @@ export namespace TypeCompiler {
 
   function* Object(schema: Types.TObject, references: Types.TSchema[], value: string): IterableIterator<string> {
     yield IsObjectCheck(value)
-    if (!TypeSystem.AllowArrayObjects) yield `!Array.isArray(${value})`
     if (IsNumber(schema.minProperties)) yield `Object.getOwnPropertyNames(${value}).length >= ${schema.minProperties}`
     if (IsNumber(schema.maxProperties)) yield `Object.getOwnPropertyNames(${value}).length <= ${schema.maxProperties}`
     const schemaKeys = globalThis.Object.getOwnPropertyNames(schema.properties)

diff --git a/src/value/check.ts b/src/value/check.ts
@@ -220,10 +220,10 @@ export namespace ValueCheck {
     if (!IsObject(value)) {
       return false
     }
-    if (IsNumber(schema.minProperties) && !(globalThis.Object.getOwnPropertyNames(value).length >= schema.minProperties)) {
+    if (IsDefined<number>(schema.minProperties) && !(globalThis.Object.getOwnPropertyNames(value).length >= schema.minProperties)) {
       return false
     }
-    if (IsNumber(schema.maxProperties) && !(globalThis.Object.getOwnPropertyNames(value).length <= schema.maxProperties)) {
+    if (IsDefined<number>(schema.maxProperties) && !(globalThis.Object.getOwnPropertyNames(value).length <= schema.maxProperties)) {
       return false
     }
     const knownKeys = globalThis.Object.getOwnPropertyNames(schema.properties)