Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apostrophe to word tokenization list allowing possessive forms #149

Merged

Conversation

janpeuker
Copy link
Contributor

@janpeuker janpeuker commented Apr 24, 2022

Fixes #148

I would like to propose adding the apostrophe symbol for word tokenization, so that the linter does not complain on possessive forms.

The integration tests don't run locally for me (due to missing API access, happy to help fix that if someone can guide me). The local tests after my addition appear unchanged (no additional failures):

  6 warnings


  9 tests failed
  2 known failures

  rules › code-of-conduct › code-of-conduct - invalid if has placeholder
  rules › code-of-conduct › code-of-conduct - invalid if just copied

In order to clearly separate the added test from the tokenization change, I have not squashed local commits. Apologies if this PR does violate the Contribution Guidelines for that. I'm happy to help in the future and happy to learn from this issue to submit better PRs in the future.

@janpeuker janpeuker changed the title Janpeuker linter fix casing and links Add apostrophe to word tokenization list allowing possessive forms Apr 24, 2022
@sindresorhus
Copy link
Owner

CI is failing

@janpeuker
Copy link
Contributor Author

CI is failing

This appears to be the same reason I experienced locally, failing GitHub integration tests (tests fail in github.js). This seems to have happened in older commits in 2021, already e.g. this one, 2 different problems:

  1. Local Tests can't possibly work because the canonical tests have symbolic links to GitHub, this probably only works with TravisCI

  2. I don't fully understand github.js, because it looks stubbed but errors returned are like "Response code 404 (Not Found)" looking for a repo "sindresorhus/awesome-lint-test.git". I will see if I find out what the problem is once I learned the stubbing technique

@FlakeysRay
Copy link

That's what you still believe

@sindresorhus sindresorhus merged commit f7ae121 into sindresorhus:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Item description should allow possessive form as first word
4 participants