Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set top limit for electron version #2073

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

dusansimic
Copy link
Collaborator

@dusansimic dusansimic commented Sep 25, 2023

This patch sets a top limit for Electron version (so it's >=24.8.3 but still remains v24). This resolves the issues with dark theme not working.

Closes: #2072
Closes: #2071


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@dusansimic dusansimic merged commit 16235b4 into sindresorhus:main Sep 25, 2023
1 check passed
@dusansimic dusansimic deleted the set-top-limit-electron branch September 25, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Themes not working Dask THeme broken and updates
1 participant