Fix fullPage option (#116)

sindresorhus · Jan 25, 2024 · 731d77f · 731d77f
1 parent 48f11f7
commit 731d77f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -377,14 +377,14 @@ const internalCaptureWebsiteCore = async (input, options, page, browser) => {
 	if (screenshotOptions.fullPage) {
 		// Get the height of the rendered page
 		const bodyHandle = await page.$('body');
-		const bodyBoundingHeight = await bodyHandle.boundingBox();
+		const bodyBoundingBox = await bodyHandle.boundingBox();
 		await bodyHandle.dispose();
 
 		// Scroll one viewport at a time, pausing to let content load
 		const viewportHeight = viewportOptions.height;
 		let viewportIncrement = 0;
-		while (viewportIncrement + viewportHeight < bodyBoundingHeight) {
-			const navigationPromise = page.waitForNavigation({waitUntil: 'networkidle0'});
+		while (viewportIncrement + viewportHeight < bodyBoundingBox.height) {
+			const navigationPromise = page.waitForNetworkIdle();
 			/* eslint-disable no-await-in-loop */
 			await page.evaluate(_viewportHeight => {
 				/* eslint-disable no-undef */

diff --git a/package.json b/package.json
@@ -45,7 +45,7 @@
 	"dependencies": {
 		"@cliqz/adblocker-puppeteer": "^1.26.11",
 		"file-url": "^4.0.0",
-		"puppeteer": "^21.5.0",
+		"puppeteer": "^21.9.0",
 		"tough-cookie": "^4.1.3"
 	},
 	"devDependencies": {