Skip to content

Commit

Permalink
fix: store failing validation after schema change
Browse files Browse the repository at this point in the history
Defer validation until after migrations are applied so that the store can be updated to the current schema.

Migrate store before validating store
  • Loading branch information
dopry committed Jun 21, 2024
1 parent a3c288b commit 74fe4c2
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions source/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,15 @@ export default class Conf<T extends Record<string, any> = Record<string, unknown

const fileStore = this.store;
const store = Object.assign(createPlainObject(), options.defaults, fileStore);

if (options.migrations) {
if (!options.projectVersion) {
throw new Error('Please specify the `projectVersion` option.');
}

this._migrate(options.migrations, options.projectVersion, options.beforeEachMigration);
}

this._validate(store);

try {
Expand All @@ -148,14 +157,6 @@ export default class Conf<T extends Record<string, any> = Record<string, unknown
if (options.watch) {
this._watch();
}

if (options.migrations) {
if (!options.projectVersion) {
throw new Error('Please specify the `projectVersion` option.');
}

this._migrate(options.migrations, options.projectVersion, options.beforeEachMigration);
}
}

/**
Expand Down

0 comments on commit 74fe4c2

Please sign in to comment.