Incomplete solution to node v10 compatibility #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails 3 tests in Node v10 - I can't quite find a way to keep cp-file's promise that it'll only create a directory for output if the output can be read from the stream - that requires waiting a tick between
readable
andpipe
and that breaks behavior much more (instead of failing 3 tests,master
fails 15.Unfortunately the Node v10 changelog only says
Which doesn't clearly point to why this would break.