Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename function gets filename with extension #110

Merged
merged 1 commit into from
May 2, 2023

Conversation

kittaakos
Copy link
Contributor

When rename is a function, the basename argument has the file extension.

Closes #109

Closes sindresorhus#109

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@sindresorhus sindresorhus merged commit cdb7ed4 into sindresorhus:main May 2, 2023
@sindresorhus
Copy link
Owner

Even though this is a bug fix, the incorrect behavior has been there long enough that this fix is a potentially breaking change, so it will have to be a major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when rename is a function, basename does not contain the file extension from 9.x
2 participants